Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 97c0ae4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c3895d31ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
|
Superseded by #9696. The replacement preserves the existing |
Array.unionandArray.unionWithdocument that they remove duplicates, andChunk.union, which delegates toArray.union, shows duplicates inside a single input being removed in its JSDoc example. The fast path for an empty operand returned the other operand untouched, so whether duplicates were removed depended on whether the other side happened to be empty:unionandunionWithnow always deduplicate the concatenated inputs, so the result is a set regardless of which operand is empty. Both dedupe helpers keep the first element, so theNonEmptyArrayoverloads still hold at runtime. Regression cases cover both operand orders forunion,unionWithandChunk.union.The
unionWithequivalence is now typed as(A | B, A | B) => boolean. Deduplication compares elements from the same side and in either order, so the previous(A, B)signature was unsound whenever both inputs were nonempty. Type tests reject a callback that only accepts(A, B).Closes EFF-2579