Skip to content

Fix Array.union keeping duplicates when one input is empty - #9616

Closed
Marve10s wants to merge 6 commits into
Effect-TS:mainfrom
Marve10s:fix/array-union-empty-dedupe
Closed

Marve10s wants to merge 6 commits into
Effect-TS:mainfrom
Marve10s:fix/array-union-empty-dedupe

Conversation

@Marve10s

@Marve10s Marve10s commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Array.union and Array.unionWith document that they remove duplicates, and Chunk.union, which delegates to Array.union, shows duplicates inside a single input being removed in its JSDoc example. The fast path for an empty operand returned the other operand untouched, so whether duplicates were removed depended on whether the other side happened to be empty:

Array.union([1, 1, 2], [2]) // [1, 2]
Array.union([1, 1, 2], [])  // [1, 1, 2]
Chunk.union(Chunk.make(1, 1, 2), Chunk.empty()) // Chunk(1, 1, 2)

union and unionWith now always deduplicate the concatenated inputs, so the result is a set regardless of which operand is empty. Both dedupe helpers keep the first element, so the NonEmptyArray overloads still hold at runtime. Regression cases cover both operand orders for union, unionWith and Chunk.union.

The unionWith equivalence is now typed as (A | B, A | B) => boolean. Deduplication compares elements from the same side and in either order, so the previous (A, B) signature was unsound whenever both inputs were nonempty. Type tests reject a callback that only accepts (A, B).

Closes EFF-2579

@changeset-bot

changeset-bot Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 97c0ae4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
effect Patch
@effect/opentelemetry Patch
@effect/vitest Patch
@effect/ai-anthropic Patch
@effect/ai-cloudflare Patch
@effect/ai-openai-compat Patch
@effect/ai-openai Patch
@effect/ai-openrouter Patch
@effect/ai-typesafe Patch
@effect/atom-react Patch
@effect/atom-solid Patch
@effect/atom-vue Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-deno Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-pglite Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/docgen Patch
@effect/doctest Patch
@effect/graphql-generator Patch
@effect/openapi-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T18:19:45.289303Z c3895d3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c3895d31ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/effect/src/Array.ts Resolved
@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name Current Size Previous Size Difference
arbitrary-combinators.ts 39.11 KB 39.11 KB 0.00 KB (0.00%)
basic.ts 7.02 KB 7.02 KB 0.00 KB (0.00%)
batching.ts 10.89 KB 10.89 KB 0.00 KB (0.00%)
brand.ts 6.71 KB 6.71 KB 0.00 KB (0.00%)
cache.ts 11.33 KB 11.33 KB 0.00 KB (0.00%)
config.ts 22.57 KB 22.57 KB 0.00 KB (0.00%)
differ.ts 21.63 KB 21.63 KB 0.00 KB (0.00%)
http-client.ts 24.10 KB 24.10 KB 0.00 KB (0.00%)
http-router.ts 35.66 KB 35.66 KB 0.00 KB (0.00%)
logger.ts 11.68 KB 11.68 KB 0.00 KB (0.00%)
metric.ts 9.26 KB 9.26 KB 0.00 KB (0.00%)
optic.ts 6.93 KB 6.93 KB 0.00 KB (0.00%)
pubsub.ts 15.77 KB 15.77 KB 0.00 KB (0.00%)
queue.ts 12.59 KB 12.59 KB 0.00 KB (0.00%)
schedule.ts 11.77 KB 11.77 KB 0.00 KB (0.00%)
schema-bigdecimal.ts 13.82 KB 13.82 KB 0.00 KB (0.00%)
schema-binary.ts 40.51 KB 40.51 KB 0.00 KB (0.00%)
schema-class.ts 21.34 KB 21.34 KB 0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts 32.30 KB 32.30 KB 0.00 KB (0.00%)
schema-representation-roundtrip.ts 27.50 KB 27.50 KB 0.00 KB (0.00%)
schema-string-transformation.ts 15.07 KB 15.07 KB 0.00 KB (0.00%)
schema-string.ts 12.08 KB 12.08 KB 0.00 KB (0.00%)
schema-template-literal.ts 16.00 KB 16.00 KB 0.00 KB (0.00%)
schema-toArbitrary.ts 38.63 KB 38.63 KB 0.00 KB (0.00%)
schema-toCodeDocument.ts 25.69 KB 25.69 KB 0.00 KB (0.00%)
schema-toCodecJson.ts 20.57 KB 20.57 KB 0.00 KB (0.00%)
schema-toEquivalence.ts 20.75 KB 20.75 KB 0.00 KB (0.00%)
schema-toFormatter.ts 20.86 KB 20.86 KB 0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts 25.50 KB 25.50 KB 0.00 KB (0.00%)
schema-toRepresentation.ts 20.85 KB 20.85 KB 0.00 KB (0.00%)
schema.ts 20.53 KB 20.53 KB 0.00 KB (0.00%)
stm.ts 13.87 KB 13.87 KB 0.00 KB (0.00%)
stream.ts 10.12 KB 10.12 KB 0.00 KB (0.00%)

gcanti commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Superseded by #9696.

The replacement preserves the existing (A, B) => boolean callback contract and fixes Array.unionWith to compare only values from opposite inputs in the declared order. It documents the deduplicated-input precondition for the union APIs and corrects the Chunk example, while retaining the empty-input shortcuts and the default union's hashing optimization.

@gcanti gcanti closed this Oct 21, 2026

This branch is waiting to be deployed

1 waiting deployment
fork — 828f256a Waiting Oct 20, 2026 by effect-bot via approval-gate #21607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants