Repository navigation
fix(platform-node): use native realpath on Windows - #9489
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 214745f The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
effect-bot
marked this pull request as ready for review
October 18, 2026 08:47
![effect-janitor[bot]](https://avatars.githubusercontent.com/in/4811166?s=60&v=4){kind=small}
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileSystem.realPathcan reject a readable Windows AppContainer workspace becausethe JavaScript callback implementation inspects an ungranted ancestor. Select
fs.realpath.nativeon Windows while preserving the existing callback/erroradapters and other platforms' implementation.
The existing filesystem test gains one directory-alias canonicalization assertion.
This is compatibility coverage, not a restricted-AppContainer reproduction.
A patch changeset covers
@effect/platform-node-shared.Author-reported validation on Windows, against the current main/package 4.0.5 source:
pnpm lint-fixand the affected package check pass.pnpm test --run packages/platform/node-shared/test/NodeFileSystem.test.tsonNode 25.6.0: 62 pass, one recursive-watch failure. Unmodified baseline: 61 pass
and the same failure. The new canonicalization test passes.
pnpm checkfails TS6133 for an unused Schedulemetadataparameter;the exact same diagnostic reproduces on the unmodified baseline.
roundtrip resolution changes from failure to success; missing paths remain
NotFound, the truly denied root remains EPERM, and owned cleanup passes.
Full-root and cross-platform checks are not green. Related Windows reproduction:
anomalyco/opencode#53508. The separate OpenCode sync
helper needs its own correction; this PR does not claim current-dev ACP coverage.
Tests-only takeover validation (Linux): filesystem suite 63/63 passed;
pnpm lint-fixand rootpnpm checkpassed. Windows AppContainer and Bunvalidation have not been independently repeated during that pass.
Independent implementation validation (Linux, Node 26.7.0 / Bun 1.3.13):
both existing error adapters and leaves other platforms unchanged.
resolved physical/alias/normalized paths. Missing paths retained ENOENT /
NotFound; actual mode-denied traversal retained EACCES / PermissionDenied and
original cause/path/syscall; NUL-containing paths retained BadArgument.
pnpm checkpassed. No tests changed.probes do not verify Windows selection, junction semantics, restricted-ancestor
access, or Windows EPERM behavior. Those results remain author-reported.
Closes EFF-2430