Skip to content

Restore MCP Skills support on legacy protocol revisions - #10540

Merged
effect-bot merged 2 commits into
mainfrom
agent/effect-bot/bf6d09a114e7
Nov 11, 2026
Merged

Restore MCP Skills support on legacy protocol revisions#10540
effect-bot merged 2 commits into
mainfrom
agent/effect-bot/bf6d09a114e7

Conversation

@effect-bot

@effect-bot effect-bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Restore opt-in Skills support in McpClient and the four legacy McpServer adapters (2024-11-05 through 2025-11-25).
  • Negotiate through legacy initialization and return legacy result shapes without modern caching attributes; keep modern behavior unchanged.
  • Preserve the scope/module-header cleanups and current shared cursor validation. Correct the minimum-version JSDoc and add a patch release note.

The Skills specification states its 2026-07-28 baseline, not a minimum supported negotiated revision. Its recorded decision explicitly replaces the SEP’s per-version caching conditional with that baseline. This corrects the compatibility regression introduced by #10342; it does not claim to reproduce historical conformance runs.

Validation

  • Regression tests failed before the source fix (7 failures) and pass afterward.
  • 123 tests pass across McpClient.test.ts, McpServer/Skills.test.ts, and McpServer/ProtocolAdapters.test.ts.
  • Legacy wire coverage includes all four adapters, extension declarations, list/get/directory methods, absent cache attributes, and invalid cursors. Client coverage exercises legacy and modern opt-in and successful Skills operations.
  • pnpm check, pnpm lint-fix, pnpm lint, and pnpm jsdocs --check pass (all via nix develop -c).
  • External conformance harness not rerun.

Closes EFF-3338

@changeset-bot

changeset-bot Bot commented Nov 11, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0be9673

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
effect Patch
@effect/opentelemetry Patch
@effect/vitest Patch
@effect/ai-amazon-bedrock Patch
@effect/ai-anthropic Patch
@effect/ai-cloudflare Patch
@effect/ai-openai-compat Patch
@effect/ai-openai Patch
@effect/ai-openrouter Patch
@effect/ai-typesafe Patch
@effect/atom-react Patch
@effect/atom-solid Patch
@effect/atom-vue Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-cloudflare Patch
@effect/platform-deno Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-pglite Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/docgen Patch
@effect/doctest Patch
@effect/graphql-generator Patch
@effect/openapi-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effect-janitor effect-janitor Bot added the 4.0 label Nov 11, 2026
@github-actions

github-actions Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name Current Size Previous Size Difference
arbitrary-combinators.ts 39.61 KB 39.61 KB 0.00 KB (0.00%)
basic.ts 7.31 KB 7.31 KB 0.00 KB (0.00%)
batching.ts 11.21 KB 11.21 KB 0.00 KB (0.00%)
brand.ts 7.00 KB 7.00 KB 0.00 KB (0.00%)
cache.ts 11.73 KB 11.73 KB 0.00 KB (0.00%)
config.ts 23.06 KB 23.06 KB 0.00 KB (0.00%)
differ.ts 22.20 KB 22.20 KB 0.00 KB (0.00%)
http-client.ts 27.44 KB 27.44 KB 0.00 KB (0.00%)
http-router.ts 37.34 KB 37.34 KB 0.00 KB (0.00%)
logger.ts 12.19 KB 12.19 KB 0.00 KB (0.00%)
metric.ts 9.64 KB 9.64 KB 0.00 KB (0.00%)
optic.ts 7.21 KB 7.21 KB 0.00 KB (0.00%)
pubsub.ts 16.21 KB 16.21 KB 0.00 KB (0.00%)
queue.ts 13.09 KB 13.09 KB 0.00 KB (0.00%)
schedule.ts 11.99 KB 11.99 KB 0.00 KB (0.00%)
schema-bigdecimal.ts 14.29 KB 14.29 KB 0.00 KB (0.00%)
schema-binary.ts 42.44 KB 42.44 KB 0.00 KB (0.00%)
schema-class.ts 21.96 KB 21.96 KB 0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts 30.56 KB 30.56 KB 0.00 KB (0.00%)
schema-representation-roundtrip.ts 28.22 KB 28.22 KB 0.00 KB (0.00%)
schema-string-transformation.ts 15.54 KB 15.54 KB 0.00 KB (0.00%)
schema-string.ts 12.50 KB 12.50 KB 0.00 KB (0.00%)
schema-template-literal.ts 16.42 KB 16.42 KB 0.00 KB (0.00%)
schema-toArbitrary.ts 39.16 KB 39.16 KB 0.00 KB (0.00%)
schema-toCodeDocument.ts 26.39 KB 26.39 KB 0.00 KB (0.00%)
schema-toCodecJson.ts 21.11 KB 21.11 KB 0.00 KB (0.00%)
schema-toEquivalence.ts 21.28 KB 21.28 KB 0.00 KB (0.00%)
schema-toFormatter.ts 21.37 KB 21.37 KB 0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts 26.38 KB 26.38 KB 0.00 KB (0.00%)
schema-toRepresentation.ts 21.45 KB 21.45 KB 0.00 KB (0.00%)
schema.ts 21.05 KB 21.05 KB 0.00 KB (0.00%)
stm.ts 14.40 KB 14.40 KB 0.00 KB (0.00%)
stream.ts 10.56 KB 10.56 KB 0.00 KB (0.00%)

@effect-bot
effect-bot merged commit 3a65e9e into main Nov 11, 2026
18 checks passed
@effect-bot
effect-bot deleted the agent/effect-bot/bf6d09a114e7 branch November 11, 2026 02:53
@effect-bot effect-bot mentioned this pull request Nov 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@effect-bot