Repository navigation
Fix TestClock interrupting masked finalizers during warning setup - #10520
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: ac86b7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the interruptible region around TestClock warning setup so a pending interruption cannot escape a finalizer’s mask.
forkChildalready creates an interruptible warning fiber by default, so clock adjustment can still cancel it.Add one regression test with a fresh clock: interrupt a fiber, verify its finalizer is still sleeping, then advance the clock and verify cleanup completes.
Validation
nix develop -c pnpm lint-fixnix develop -c pnpm checkCloses EFF-3605