Skip to content

Commit fffd88b

Browse files
fubhytim-smart
andauthored
Add reproduction for Persistence issue (#6868)
Co-authored-by: Tim Smart <[email protected]>
1 parent 39ed94a commit fffd88b

3 files changed

Lines changed: 29 additions & 3 deletions

File tree

‎.changeset/calm-redis-clear.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"effect": patch
3+
---
4+
5+
Ensure clearing an empty Redis-backed persistence store succeeds.

‎packages/effect/src/unstable/persistence/Persistence.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -965,7 +965,7 @@ export const layerBackingRedis: Layer.Layer<
965965
({ cause }) => new PersistenceError({ message: `Failed to remove key ${key} from Redis`, cause })
966966
),
967967
clear: redis.send<Array<string>>("KEYS", `${prefix}:*`).pipe(
968-
Effect.flatMap((keys) => redis.send("DEL", ...keys)),
968+
Effect.flatMap((keys) => keys.length === 0 ? Effect.void : redis.send("DEL", ...keys)),
969969
Effect.mapError(({ cause }) =>
970970
new PersistenceError({
971971
message: `Failed to clear keys from Redis`,

‎packages/effect/test/unstable/persistence/Redis.test.ts‎

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { assert, describe, it } from "@effect/vitest"
2-
import { Effect } from "effect"
3-
import { Redis } from "effect/unstable/persistence"
2+
import { Effect, Layer } from "effect"
3+
import { Persistence, Redis } from "effect/unstable/persistence"
44

55
describe("Redis", () => {
66
it("preserves __proto__ as an own script option", () => {
@@ -15,6 +15,27 @@ describe("Redis", () => {
1515
assert.strictEqual((script as any)["__proto__"], value)
1616
})
1717

18+
it.effect("clearing an empty persistence store succeeds", () => {
19+
const redis = Redis.Redis.of({
20+
send: <A>(command: string, ...args: ReadonlyArray<string>) => {
21+
if (command.toUpperCase() === "KEYS") return Effect.succeed([] as unknown as A)
22+
if (command.toUpperCase() === "DEL" && args.length === 0) {
23+
return Effect.fail(new Redis.RedisError({ cause: "ERR wrong number of arguments for 'del' command" }))
24+
}
25+
return Effect.succeed(undefined as unknown as A)
26+
},
27+
eval: () => () => Effect.die("unused")
28+
})
29+
return Effect.gen(function*() {
30+
const backing = yield* Persistence.BackingPersistence
31+
const store = yield* backing.make("empty")
32+
yield* store.clear
33+
}).pipe(
34+
Effect.scoped,
35+
Effect.provide(Persistence.layerBackingRedis.pipe(Layer.provide(Layer.succeed(Redis.Redis, redis))))
36+
)
37+
})
38+
1839
it.effect("retries script loading when SCRIPT LOAD fails", () =>
1940
Effect.gen(function*() {
2041
const commands: Array<readonly [command: string, args: ReadonlyArray<string>]> = []

0 commit comments

Comments
 (0)