Skip to content

Commit f388104

Browse files
committed
docs: clarify SQLite ID precision release note
1 parent b1310af commit f388104

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

‎.changeset/sqlite-message-storage-exact-ids.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
"effect": patch
33
---
44

5-
`SqlMessageStorage` reads SQLite snowflake ids as text, so ids above 2^53 stay exact on drivers that return integers as JavaScript numbers, including Cloudflare Durable Objects.
5+
Fix `SqlMessageStorage` ID precision loss on SQLite drivers that return numbers, including Cloudflare Durable Objects.

‎packages/effect/src/cluster/SqlMessageStorage.ts‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -277,9 +277,8 @@ const makeEncodedStorage = Effect.fnUntraced(function*(
277277
const sqlFalse = sql.literal(supportsBooleans ? "FALSE" : "0")
278278
const sqlTrue = sql.literal(supportsBooleans ? "TRUE" : "1")
279279

280-
// SQLite INTEGER comes back as a JavaScript number on drivers that cannot
281-
// honor SafeIntegers, including Durable Objects. Snowflakes are above
282-
// 2^53, so read the id columns as text and keep the stored digits exact.
280+
// Read SQLite IDs as text to avoid rounding on number-returning drivers
281+
// such as Durable Objects.
283282
const idsAsText = sql.onDialectOrElse({
284283
sqlite: () => true,
285284
orElse: () => false

0 commit comments

Comments
 (0)