Skip to content

Commit b650832

Browse files
fubhytim-smart
andauthored
Keep Stream.range advancing with a zero-sized chunk (#6900)
Co-authored-by: Tim Smart <[email protected]>
1 parent c8fd57e commit b650832

3 files changed

Lines changed: 19 additions & 3 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"effect": patch
3+
---
4+
5+
Ensure `Stream.range` emits the full range when the chunk size is zero.

‎packages/effect/src/Stream.ts‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1570,14 +1570,15 @@ export const range = (
15701570
chunkSize = Channel.DefaultChunkSize
15711571
): Stream<number> =>
15721572
min > max ? empty : fromPull(Effect.sync(() => {
1573+
const size = Math.max(1, chunkSize)
15731574
let start = min
15741575
let done = false
15751576
return Effect.suspend(() => {
15761577
if (done) return Cause.done()
15771578
const remaining = max - start + 1
1578-
if (remaining > chunkSize) {
1579-
const chunk = Arr.range(start, start + chunkSize - 1)
1580-
start += chunkSize
1579+
if (remaining > size) {
1580+
const chunk = Arr.range(start, start + size - 1)
1581+
start += size
15811582
return Effect.succeed(chunk)
15821583
}
15831584
const chunk = Arr.range(start, start + remaining - 1)

‎packages/effect/test/Stream.test.ts‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -404,6 +404,16 @@ describe("Stream", () => {
404404
assert.deepStrictEqual(result, [1, 2, 3])
405405
}))
406406

407+
it.effect("range - zero chunk size does not change the emitted range", () =>
408+
Effect.gen(function*() {
409+
const result = yield* Stream.range(1, 3, 0).pipe(
410+
Stream.take(4),
411+
Stream.runCollect
412+
)
413+
414+
assert.deepStrictEqual(result, [1, 2, 3])
415+
}))
416+
407417
it.effect("service", () =>
408418
Effect.gen(function*() {
409419
const result = yield* Stream.service(Greeter).pipe(

0 commit comments

Comments
 (0)