Skip to content

Commit 8fe8fb1

Browse files
fix(http): read response cookies when Headers has no getSetCookie
React Native's Headers implementation does not provide getSetCookie, so reading HttpClientResponse.cookies threw a TypeError there. Treat a missing getSetCookie as no Set-Cookie headers. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
1 parent b1d200c commit 8fe8fb1

3 files changed

Lines changed: 17 additions & 2 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"effect": patch
3+
---
4+
5+
Read `HttpClientResponse.cookies` on platforms whose `Headers` has no `getSetCookie`, such as React Native, instead of throwing.

‎packages/effect/src/http/HttpClientResponse.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,9 @@ class WebHttpClientResponse extends Inspectable.Class implements HttpClientRespo
315315
if (this.cachedCookies) {
316316
return this.cachedCookies
317317
}
318-
return this.cachedCookies = Cookies.fromSetCookie(this.source.headers.getSetCookie())
318+
// React Native's Headers does not implement getSetCookie, and it never
319+
// exposes Set-Cookie to JavaScript anyway.
320+
return this.cachedCookies = Cookies.fromSetCookie(this.source.headers.getSetCookie?.() ?? [])
319321
}
320322

321323
get remoteAddress(): Option.Option<string> {

‎packages/effect/test/http/HttpClient.test.ts‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { assert, describe, it } from "@effect/vitest"
22
import { strictEqual } from "@effect/vitest/utils"
33
import { Clock, Duration, Effect, Fiber, Layer, Ref, Schema, Stream } from "effect"
4-
import { HttpClient, HttpClientRequest, HttpClientResponse } from "effect/http"
4+
import { Cookies, HttpClient, HttpClientRequest, HttpClientResponse } from "effect/http"
55
import { RateLimiter } from "effect/persistence"
66
import { TestClock } from "effect/testing"
77
import * as Tracer from "effect/Tracer"
@@ -1360,4 +1360,12 @@ Missing key
13601360
strictEqual(yield* Ref.get(attempts), 3)
13611361
}).pipe(Effect.provide(RateLimiter.layerStoreMemory)))
13621362
})
1363+
1364+
it("reads cookies when Headers has no getSetCookie", () => {
1365+
// React Native's Headers implementation does not provide getSetCookie.
1366+
const source = new Response(null, { headers: { "content-type": "text/plain" } })
1367+
Object.defineProperty(source.headers, "getSetCookie", { value: undefined })
1368+
const response = HttpClientResponse.fromWeb(HttpClientRequest.get("http://localhost"), source)
1369+
assert.isTrue(Cookies.isEmpty(response.cookies))
1370+
})
13631371
})

0 commit comments

Comments
 (0)