Skip to content

Commit 4a0984a

Browse files
fubhytim-smart
andauthored
Add reproduction for Persistence issue (#6869)
Co-authored-by: Tim Smart <[email protected]>
1 parent 979ce39 commit 4a0984a

3 files changed

Lines changed: 20 additions & 10 deletions

File tree

‎.changeset/calm-keys-repeat.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"effect": patch
3+
---
4+
5+
Fix SQL-backed Persistence `getMany` to preserve duplicate key positions.

‎packages/effect/src/unstable/persistence/Persistence.ts‎

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -414,18 +414,16 @@ export const layerBackingSqlMultiTable: Layer.Layer<
414414
})
415415
),
416416
Effect.flatMap((rows) => {
417-
const out = new Array<object | undefined>(keys.length)
417+
const values = new Map<string, object>()
418418
for (let i = 0; i < rows.length; i++) {
419419
const row = rows[i]
420-
const index = keys.indexOf(row.id)
421-
if (index === -1) continue
422420
try {
423-
out[index] = JSON.parse(row.value)
421+
values.set(row.id, JSON.parse(row.value))
424422
} catch {
425423
// ignore
426424
}
427425
}
428-
return Effect.succeed(out as Arr.NonEmptyArray<object | undefined>)
426+
return Effect.succeed(keys.map((key) => values.get(key)) as Arr.NonEmptyArray<object | undefined>)
429427
})
430428
),
431429
set: (key, value, ttl) =>
@@ -761,18 +759,16 @@ export const layerBackingSql: Layer.Layer<
761759
})
762760
),
763761
Effect.flatMap((rows) => {
764-
const out = new Array<object | undefined>(keys.length)
762+
const values = new Map<string, object>()
765763
for (let i = 0; i < rows.length; i++) {
766764
const row = rows[i]
767-
const index = keys.indexOf(row.id)
768-
if (index === -1) continue
769765
try {
770-
out[index] = JSON.parse(row.value)
766+
values.set(row.id, JSON.parse(row.value))
771767
} catch {
772768
// ignore
773769
}
774770
}
775-
return Effect.succeed(out as Arr.NonEmptyArray<object | undefined>)
771+
return Effect.succeed(keys.map((key) => values.get(key)) as Arr.NonEmptyArray<object | undefined>)
776772
})
777773
),
778774
set: (key, value, ttl) =>

‎packages/sql/sqlite-node/test/Persistence.test.ts‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,15 @@ const suite = (name: string, layer: Layer.Layer<Persistence.BackingPersistence,
5454
])
5555
}))
5656

57+
it.effect("getMany with duplicate keys", () =>
58+
Effect.gen(function*() {
59+
const persistence = yield* Persistence.BackingPersistence
60+
const store = yield* persistence.make("test_store_duplicate_keys")
61+
yield* store.set("key", { value: 1 }, undefined)
62+
63+
expect(yield* store.getMany(["key", "key"])).toEqual([{ value: 1 }, { value: 1 }])
64+
}))
65+
5766
it.effect("remove", () =>
5867
Effect.gen(function*() {
5968
const persistence = yield* Persistence.BackingPersistence

0 commit comments

Comments
 (0)