security: set-output cmd deprecated. Use $GITHUB_OUTPUT env file
#9287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid untrusted logged data to use `save-state` and `set-output` workflow commands without the intention of the workflow author we have introduced a new set of environment files to manage state and output. Starting 1st June 2023 workflows using `save-state` or `set-output` commands via stdout will fail with an error. https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Member
Author
|
Doing some tests to know how to fix awesomebot GitHub summary report Compare:
|
davorpa
added
the
👀 Needs Review
Member
Author
Now it works again: https://github.com/EbookFoundation/free-programming-books/actions/runs/4243200736 |
Thenlie
reviewed
Feb 22, 2023
Thenlie
approved these changes
Feb 22, 2023
Contributor
There was a problem hiding this comment.
This all looks good to me. ✅
- No instances of
set-outputorsave-statewere missed in the workflow files. Verified with spotlight search of the repo. - Workflow checks are passing and output is properly formatted.
My only nit would be to squash these test commits into one.
davorpa
added a commit
to davorpa/free-programming-books
that referenced
this pull request
Feb 23, 2023
::set-output --> GITHUB_OUTPUT env file
eshellman
pushed a commit
that referenced
this pull request
Feb 24, 2023
* ci(check-urls): use a matrix to speed-up execution The matrix strategy creates 10 max-parallel workers with a disabled fail-fast parameter Examples - Before: https://github.com/davorpa/free-programming-books/actions/runs/2999590952 - After: https://github.com/davorpa/free-programming-books/actions/runs/3007199364 Running the workflow when -langs or -subject files are involved could exhaust the runner execution max-time. Using this implementation... the elapsed time is of the longest execution time, normally no more than 30min on the worst of cases * fix: parallel strategy when matrix files.length == 0 * security: apply #9287 ::set-output --> GITHUB_OUTPUT env file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve repo
For resources
Description
Starting 1st June 2023 workflows using
save-stateorset-outputcommands via stdout will fail with an error.More info:
Why is this valuable (or not)?
It patches the deprecation
Checklist:
Follow-up