Repository navigation
fix(macos): disable Impeller pending upstream crash fix - #107
Merged
Merged
Conversation
AhmedAttia3
added
release-reviewed
AhmedAttia3
added a commit
that referenced
this pull request
Nov 8, 2026
Restore Skia on macOS while flutter/flutter#185394 remains unresolved, enforce the resolved release plist setting, and document the temporary release invariant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Goal
Flutter 3.47 enables Impeller by default on macOS, exposing the open P1 engine crash in flutter/flutter#185394. The failure invalidates a Metal texture when its descriptor size disagrees with the backing texture and can terminate the client during foreground, resize, or window lifecycle transitions.
Technical Changes
FLTEnableImpellertofalsefor the macOS Client, restoring the previously used Skia rendering path.Other platforms are unchanged.
Verification
plutil -lint macos/Runner/Info.plistbash -n release/macos/build_macos_dmg.shfvm flutter test test/tool/desktop_window_contract_test.dart— 11 passedfvm flutter analyze— no issuesfvm flutter build macos --debug— succeededSanad.app/Contents/Info.plistreportsFLTEnableImpeller = falseFollow-up
Run a one-day macOS soak before preparing the patch release. Re-enable Impeller only after an upstream stable engine fix and successful macOS soak verification.