Conversation
| test_parameters = ( | ||
| a = (1.0f0, 0.0f0, 5.0f0), | ||
| b = (2.0f0, 0.0f0, 10.0f0), | ||
| c = (0.5f0, 0.0f0, 2.0f0) |
Collaborator
There was a problem hiding this comment.
What is the c needed for?
lazarusA
commented
Aug 26, 2025
| @test haskey(output.parameters, :nn1) | ||
| @test haskey(output.parameters, :nn2) | ||
| @test haskey(output.parameters, :b) | ||
| @test haskey(output.parameters, :c) |
Member
Author
There was a problem hiding this comment.
@BernhardAhrens we test the existence of it here. If the model doesn't have it then the test fails. Of course we could simply it by removing it, hence, the ask, I'm not sure how did you plan/intended for this to be generally used?
| end | ||
|
|
||
| # Mechanistic model for MultiNNHybridModel: accepts either a (from params) or nn1 (from NN) | ||
| function test_mechanistic_model_multi(; x1, a=nothing, b=nothing, c=nothing, nn1=nothing, nn2=nothing) |
Collaborator
There was a problem hiding this comment.
Suggested change
| function test_mechanistic_model_multi(; x1, a=nothing, b=nothing, c=nothing, nn1=nothing, nn2=nothing) | |
| function test_mechanistic_model_multi(; x1, a=nothing, b=nothing, c=nothing) |
To me, this would not be an intended way of defining things. The definitions in constructHybridModel would take care of this anyways
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.