Repository navigation
Commit 691e396
Reduce repeated ACP session context (block#5423)
## Summary
- deliver legacy ACP standing context once per live session, committing
delivery state only after a successful turn
- send only new thread/DM event deltas on later turns, with fail-open
behavior for missing IDs and failed/cancelled prompts
- fence native steer delivery acknowledgements by ACP session identity
so stale acks cannot poison replacement sessions
- keep context hints truthful when a fetch contains only the triggering
event versus history delivered earlier
## Validation
The pre-push hook passed on exact pushed head
`6a768f1bc80fe63c686acf8d730f177fff8add3c`:
- `branch-skew`
- `desktop-check`
- `desktop-typecheck`
- `desktop-test`
- `rust-tests`
- `desktop-tauri-checks`
Focused regression tests were also run while iterating:
- `channel_prompt_commits_delivery_state_only_after_acp_success`
- `in_flight_stale_native_steer_ack_cannot_update_replacement_session`
- thread/DM trigger-only versus previously-delivered context hint tests
## Known limitations and follow-ups
A local Goose smoke timed out at `session/new`. This diff does not
change code that executes at or before `session/new`; its earliest
affected runtime behavior is delivery-state insertion after session
creation succeeds. The smoke failure is therefore bounded as
environmental or pre-existing, but no successful live-provider turn was
obtained. Scripted ACP wire/lifecycle tests carry the regression
coverage.
- block#5421 — distinguish post-delta, already-delivered, and fetch-truncated
context counts
- block#5422 — define a standing-context re-delivery policy if a legacy
provider compacts it away
Durable process-restart/session resume remains out of scope for this
slice of block#5342. block#5386 also remains separate pending upstream adapter
support.
---------
Signed-off-by: Wes <[email protected]>
Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>
Signed-off-by: bhargavms <[email protected]>1 parent 3d2ac22 commit 691e396
4 files changed
Lines changed: 1585 additions & 176 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1617 | 1617 | | |
1618 | 1618 | | |
1619 | 1619 | | |
1620 | | - | |
| 1620 | + | |
| 1621 | + | |
| 1622 | + | |
1621 | 1623 | | |
1622 | 1624 | | |
1623 | 1625 | | |
| |||
1629 | 1631 | | |
1630 | 1632 | | |
1631 | 1633 | | |
1632 | | - | |
| 1634 | + | |
| 1635 | + | |
| 1636 | + | |
1633 | 1637 | | |
1634 | 1638 | | |
1635 | 1639 | | |
| |||
3799 | 3803 | | |
3800 | 3804 | | |
3801 | 3805 | | |
3802 | | - | |
| 3806 | + | |
3803 | 3807 | | |
3804 | 3808 | | |
3805 | 3809 | | |
| |||
3860 | 3864 | | |
3861 | 3865 | | |
3862 | 3866 | | |
3863 | | - | |
| 3867 | + | |
3864 | 3868 | | |
3865 | 3869 | | |
3866 | 3870 | | |
| |||
4044 | 4048 | | |
4045 | 4049 | | |
4046 | 4050 | | |
4047 | | - | |
| 4051 | + | |
4048 | 4052 | | |
4049 | 4053 | | |
4050 | 4054 | | |
| |||
4076 | 4080 | | |
4077 | 4081 | | |
4078 | 4082 | | |
4079 | | - | |
| 4083 | + | |
4080 | 4084 | | |
4081 | 4085 | | |
4082 | 4086 | | |
| |||
4181 | 4185 | | |
4182 | 4186 | | |
4183 | 4187 | | |
4184 | | - | |
| 4188 | + | |
4185 | 4189 | | |
4186 | 4190 | | |
4187 | 4191 | | |
| |||
4238 | 4242 | | |
4239 | 4243 | | |
4240 | 4244 | | |
4241 | | - | |
| 4245 | + | |
4242 | 4246 | | |
4243 | 4247 | | |
4244 | 4248 | | |
| |||
0 commit comments