Repository navigation
fix(sdk): support standard ethers wallets for direct EIP-7594 submission - #116
Merged
Merged
Conversation
Contributor
Author
|
Quick follow-up, @n8wb. Could you take a look at the ethers wallet submission path when you have a chance? Thanks. |
Member
|
Hello, @arunimshukla fix looks good, merged it. What do you mean by "ethers wallet submission path"? |
Contributor
Author
|
Thanks for merging, @n8wb! By “ethers wallet submission path,” I meant submitting an EIP-7594 blob transaction directly through the SDK using a standard ethers wallet. I was referring to the flow fixed in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113. Direct EIP-7594 submission called
signRawTransactionon every signer, although a normal ethers Wallet does not have that custom method. The SDK type also incorrectly made that method mandatory.This accepts a standard ethers BaseWallet and signs the hash of the unsigned serialized blob transaction with its signing key. Existing custom raw transaction signers retain their path. Unsupported signers receive a clear error. Three tests cover wallet signature recovery, the custom signer path, and the unsupported signer error.