Pin numpy !=1.24.3 due to severe masking bug #3182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriupredoi
changed the title
Contributor
Author
|
@esmvalbot please run recipe_ocean_quadmap.yml |
|
Since @valeriupredoi asked, ESMValBot will run recipe recipe_ocean_quadmap.yml as soon as possible, output will be generated here |
|
ESMValBot is happy to report recipe recipe_ocean_quadmap.yml ran OK, output has been generated here |
Contributor
Author
|
@TomasTorsvik have a look at the bot's plots - they're not funky anymore 😁 |
remi-kazeroni
approved these changes
May 19, 2023
Contributor
remi-kazeroni
left a comment
remi-kazeroni
left a comment
There was a problem hiding this comment.
Thanks for taking care of this @valeriupredoi! The esmvalbot run displays a normal plot now, using numpy=1.24.2 and iris=3.6.0 (see env file) 🥳
Contributor
Author
|
no more Phunkphenomenon 😁 Would you mind merging @remi-kazeroni please - cheers for the review 🍺 |
Contributor
Author
|
many thanks @remi-kazeroni 🍻 |
FranziskaWinterstein
pushed a commit
that referenced
this pull request
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many thanks to @TomasTorsvik for alerting us and to @remi-kazeroni for identifying the offending dependency 🍺 x2
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.