Porting flato13 fig9 6 #1384

bettina-gier · 2019-10-16T11:02:02Z

Porting flato13ipcc fig 9-6. Current recipe includes CMIP3 data requiring the merge of ESMValGroup/ESMValCore#269 (Support CMIP3). Documentation included, enjoy the ncl code!

Tasks

Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
Give this pull request a descriptive title that can be used as a one line summary in a changelog
Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
Please use yamllint to check that your YAML files do not contain mistakes
Update documentation for the recipe to the doc/sphinx/source/recipes folder

Closes #693

…on2_flato13_fig9-6

esmvaltool/recipes/recipe_flato13ipcc.yml

bouweandela · 2019-10-17T09:34:40Z

esmvaltool/recipes/recipe_flato13ipcc.yml

+      - {<<: *cmip3, dataset: cccma_cgcm3_1, institute: CCCMA}
+      - {<<: *cmip3, dataset: cccma_cgcm3_1_t63, institute: CCCMA}
+      - {<<: *cmip3, dataset: csiro_mk3_0, institute: CSIRO}
+      # - {<<: *cmip3, dataset: gfdl_cm2_0, institute: GFDL}


Why all the commented out datasets?

Data available but filenames have a dot before .nc and ESMValTool doesn't find them

It would be good to report that in the pull request that adds support for CMIP3 to ESMValCore, so it can be fixed there.

bouweandela · 2019-10-17T11:14:57Z

Could you please resolve the merge conflict by merging the version2_development branch into this branch?

…on2_flato13_fig9-6

mattiarighi · 2019-12-19T09:32:50Z

Please resolve the conflicts.
Please open a PR in ESMValCore to address the CMIP3 filename issue, as suggested by @bouweandela above.
PR #269 needs to be merged first.

mattiarighi · 2020-01-15T13:51:53Z

Apparently I miss some of the CMIP3 datasets, e.g. for swcre.
Did you test this at DKRZ or on another machine?

bettina-gier · 2020-01-20T14:30:05Z

Yeah was tested on DKRZ, seems like on the institution change the models were changed as well, try the list of models from before commit f8bb3b3
(Last time I ran it was during the workshop, /work/bd0854/b309137/v2_split/output/recipe_flato13ipcc_fig9-6_20191016_071703 on DKRZ if you want to compare)

mattiarighi · 2020-01-21T08:02:08Z

Can you update the recipe by including only the models currently available at DKRZ that run without errors?

LisaBock · 2020-01-21T09:34:27Z

Can you update the recipe by including only the models currently available at DKRZ that run without errors?

Recipe is now updated and I tested it again. Works fine on Mistral...

mattiarighi · 2020-01-21T16:47:43Z

It works now, thanks.
I keep forgetting that CMIP3 models run only in serial mode, so I added a note in the recipe description section. Hope this is fine with you @bettina-gier @LisaBock

Bettina Gier and others added 17 commits November 2, 2018 16:47

Porting flato13 fig 9.6

761db21

Failed try at fixing tas for EC-EARTH, added name to developer list

5cd0923

Merge development into ipccfig9_6

82e2595

Adapted AR5 Fig 9.6 to new ncl interface

8ab4677

Fixed errors in AR5 Fig 9.6: alt_obs, index error in collect script

fe974cc

Merging in development branch

5c1161f

Updating to new development version

0a70dec

Fig 9.6. Added alphabetical sorting, provenance

cad2a09

Merge branch 'version2_development' into version2_flato13_fig9-6

932ea7e

delete fix file as mv to core

3cf902d

small changes in for 9_6 figure

768e18b

add CMIP3 and customized diag order

4bf14d5

Merge remote-tracking branch 'public/version2_development' into versi…

eb3dde6

…on2_flato13_fig9-6

code style

6fd7817

Adjusted recipe, provenance for flato13 fig9-6

4e8fda2

Fixed codestyle issues

b424c30

Documentation for flato13ipcc fig 9-6

65e41ae

mattiarighi requested review from LisaBock, axel-lauer and hb326 October 16, 2019 11:14

Fixed Typo

68fd551

LisaBock approved these changes Oct 17, 2019

View reviewed changes

bouweandela reviewed Oct 17, 2019

View reviewed changes

esmvaltool/recipes/recipe_flato13ipcc.yml Show resolved Hide resolved

bouweandela reviewed Oct 17, 2019

View reviewed changes

LisaBock and others added 4 commits October 17, 2019 14:18

Merge remote-tracking branch 'public/version2_development' into versi…

500ce4a

…on2_flato13_fig9-6

delete institute for CMIP3 models in recipe

f8bb3b3

remove field from recipe

aa4018c

fix duplicate fig name

4a270ee

mattiarighi added the diagnostic label Oct 21, 2019

LisaBock and others added 4 commits November 5, 2019 11:42

remove field from diag_script

197baf5

Merge remote-tracking branch 'public/version2_development' into versi…

5a73157

…on2_flato13_fig9-6

Merge branch 'version2_development' into version2_flato13_fig9-6

c52a6f6

Use full names in header

e38a531

mattiarighi added 2 commits January 2, 2020 15:01

Remove erroneous character at the beginning

5209266

Merge branch 'version2_development' into version2_flato13_fig9-6

6e6f95f

mattiarighi changed the base branch from version2_development to master January 3, 2020 17:56

mattiarighi mentioned this pull request Jan 15, 2020

CMIP3 processing does not work in parallel mode ESMValGroup/ESMValCore#430

Closed

Merge branch 'master' into version2_flato13_fig9-6

1fb5bb5

update recipe for fig9-6

65b07ce

LisaBock and others added 3 commits January 21, 2020 11:09

delete figure numbers in documentation

b28fb6a

Merge branch 'master' into version2_flato13_fig9-6

b962314

Add caveat on CMIP3 models

154ec0b

mattiarighi approved these changes Jan 21, 2020

View reviewed changes

mattiarighi merged commit d3368c6 into master Jan 21, 2020

mattiarighi deleted the version2_flato13_fig9-6 branch January 21, 2020 17:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Porting flato13 fig9 6 #1384

Porting flato13 fig9 6 #1384

Uh oh!

bettina-gier commented Oct 16, 2019 •

edited by LisaBock

Loading

Uh oh!

Uh oh!

bouweandela Oct 17, 2019

Uh oh!

bettina-gier Oct 17, 2019

Uh oh!

bouweandela Nov 1, 2019

Uh oh!

bouweandela commented Oct 17, 2019

Uh oh!

mattiarighi commented Dec 19, 2019 •

edited

Loading

Uh oh!

mattiarighi commented Jan 15, 2020

Uh oh!

bettina-gier commented Jan 20, 2020

Uh oh!

mattiarighi commented Jan 21, 2020

Uh oh!

LisaBock commented Jan 21, 2020

Uh oh!

mattiarighi commented Jan 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Porting flato13 fig9 6 #1384

Porting flato13 fig9 6 #1384

Uh oh!

Conversation

bettina-gier commented Oct 16, 2019 • edited by LisaBock Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

bouweandela Oct 17, 2019

Choose a reason for hiding this comment

Uh oh!

bettina-gier Oct 17, 2019

Choose a reason for hiding this comment

Uh oh!

bouweandela Nov 1, 2019

Choose a reason for hiding this comment

Uh oh!

bouweandela commented Oct 17, 2019

Uh oh!

mattiarighi commented Dec 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattiarighi commented Jan 15, 2020

Uh oh!

bettina-gier commented Jan 20, 2020

Uh oh!

mattiarighi commented Jan 21, 2020

Uh oh!

LisaBock commented Jan 21, 2020

Uh oh!

mattiarighi commented Jan 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bettina-gier commented Oct 16, 2019 •

edited by LisaBock

Loading

mattiarighi commented Dec 19, 2019 •

edited

Loading