Check coordinates do not have repeated standard names #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if coord.standard_name in standard_names: | ||
| coords = [c.var_name for c in self._cube.coords( | ||
| standard_name=coord.standard_name) | ||
| ] |
Contributor
There was a problem hiding this comment.
any way we can fix this on the fly and report a warning rather than just collecting the duplicates and reporting an error?
Contributor
Author
There was a problem hiding this comment.
If you think of a way to decide consistently which is the good one, yes. I am not sure about how to do it
schlunma
approved these changes
Mar 17, 2020
Contributor
schlunma
left a comment
schlunma
left a comment
There was a problem hiding this comment.
Successfully tested with the datasets mentioned in #537:
esmvalcore.cmor.check.CMORCheckError: There were errors in variable tos:
There are multiple coordinates with standard_name "latitude": ['lat', 'latitude']
There are multiple coordinates with standard_name "longitude": ['lon', 'longitude']
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you start, please read CONTRIBUTING.md.
Tasks
yamllintto check that your YAML files do not contain mistakesIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes #373