Skip to content

Conversation

@schlunma
Copy link
Contributor

@schlunma schlunma commented Nov 11, 2019

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • If writing a new/modified preprocessor function, please update the documentation
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • If you make backward incompatible changes to the recipe format, make a new pull request in the ESMValTool repository and add the link below

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes #371

@schlunma schlunma added the fix for dataset Related to dataset-specific fix files label Nov 11, 2019
@schlunma schlunma requested a review from bouweandela November 11, 2019 10:21
@schlunma schlunma self-assigned this Nov 11, 2019
@schlunma schlunma merged commit 0a87269 into development Nov 13, 2019
@schlunma schlunma deleted the fix_gfdl_cm4 branch November 13, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix for dataset Related to dataset-specific fix files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix for GFDL-CM4 not always necessary

3 participants