Add fixes to near-surface uas, vas and tas metadata #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zklaus
requested changes
Oct 22, 2019
zklaus
left a comment
zklaus
left a comment
There was a problem hiding this comment.
Nice work! There is no need for a special add_scalar_height_coord_10 function though. See the comments in the source code.
Contributor
Author
Done! I like to make things more complicated than they are, apparently! |
zklaus
reviewed
Oct 22, 2019
added 2 commits
October 22, 2019 18:31
zklaus
reviewed
Oct 23, 2019
zklaus
reviewed
Oct 23, 2019
zklaus
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes incomplete GFDL-CM4 metadata for variables uas, vas and tas, by adding the scalar coordinate "height".
Script shared.py has been changed accordingly, and the new file gfdl_cm4.py has been created.