Development multi model statistics bugfix #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
While we're at it, we should probably replace the hard-wired calls to |
Contributor
Author
|
Hey, can anyone have a look at this please? (@valeriupredoi?) It's only a few lines and it fixes a bug in the multi model statistics. |
Contributor
|
Sure, cheers man, will have a look in a jiffy, sorry been totally occupied
by Met Office code lately 🍺
Dr Valeriu Predoi.
Computational scientist
NCAS-CMS
University of Reading
Department of Meteorology
Reading RG6 6BB
United Kingdom
…On Tue, 24 Sep 2019, 09:40 Lee de Mora, ***@***.***> wrote:
Hey, can anyone have a look at this please? ***@***.***
<https://github.com/valeriupredoi>?) It's only a few lines and it fixes a
bug in the multi model statistics.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#267?email_source=notifications&email_token=AG5EFI5BNXOQ2VWMOMNLN4DQLHHADA5CNFSM4IYVH77KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7NSSMA#issuecomment-534456624>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG5EFI6CJ64HPFZNCPHS5HDQLHHADANCNFSM4IYVH77A>
.
|
Contributor
Author
|
Cheers @valeriupredoi ! |
mattiarighi
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change to address the bug highlighted in #266. (The
multi_model_statisticspreprocessor still assumes that all cubes have latitude and longitude components and this PR hides the loading oflatsandlonsarrays behind an if statement.