Skip to content

Adding EOPF-GEOZARR flag to all 'stac_discovery/processing:software' attributes - #310

Merged
emmanuelmathot merged 3 commits into
EOPF-Explorer:mainfrom
shollendEODC:feat/include-geozarr-version
Oct 15, 2026
Merged

emmanuelmathot merged 3 commits into
EOPF-Explorer:mainfrom
shollendEODC:feat/include-geozarr-version

Conversation

@shollendEODC

Copy link
Copy Markdown
Collaborator

As described here #295 this small PR adds the geozarr metadata to the stac_discovery.

Its just the current git tag:

"processing:software": {
          "Sentinel-1 IPF": "003.71",
          "EOPF_CPM": "3.0.0",
          "COMMON_PFSD": "3.0.0",
          "SPECIFIC_PFSD": "4.1.0",
          "EOPF_MAPPING": "1.0.0",
          "EOPF_MODEL": "1.0.0",
          "EOPF_GEOZARR": "v0.12.0-50-g039f38c-dirty"
        },

@shollendEODC

Copy link
Copy Markdown
Collaborator Author

PR will be closed for now to focus on the full inclusion of S2 MS and refactors into the main branch (and to fix tests later on)

@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/eopf_geozarr/conversion/utils.py 89.28% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@shollendEODC

shollendEODC commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator Author

Apart from the subprocess routine we could also implement it like this:

version = importlib.metadata.version("eopf-geozarr")  # eg.: '0.12.0'
"processing:software": {
          "Sentinel-1 IPF": "003.71",
          "EOPF_CPM": "3.0.0",
          "COMMON_PFSD": "3.0.0",
          "SPECIFIC_PFSD": "4.1.0",
          "EOPF_MAPPING": "1.0.0",
          "EOPF_MODEL": "1.0.0",
          "EOPF_GEOZARR": f"v{version}"
        },

I would stick with the implemented method of the subprocess as it allows us to keep a clearer versioning history if we produce data not from a tag but from specific commits.

Apart from that, its ready for review @everyone and @claxn

@emmanuelmathot emmanuelmathot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to get the version from the module instead of a subprocess?

@shollendEODC

Copy link
Copy Markdown
Collaborator Author

Any way to get the version from the module instead of a subprocess?

Addressed by switching to pygit2, recommended by claude but i dont know this package and it adds a dependency. But it worked fine in my preliminary tests:

"processing:software": {
          "Sentinel-1 IPF": "003.71",
          "EOPF_CPM": "3.0.0",
          "COMMON_PFSD": "3.0.0",
          "SPECIFIC_PFSD": "4.1.0",
          "EOPF_MAPPING": "1.0.0",
          "EOPF_MODEL": "1.0.0",
          "EOPF_GEOZARR": "v0.12.0-10-gc0b9dc5-dirty"
        },

@emmanuelmathot
emmanuelmathot merged commit 67bb196 into EOPF-Explorer:main Oct 15, 2026
8 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants