You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Extension of functionalities to all other modes #248
I did some tests with more dataproducts to check if and how they are working (X not working, Y working). From these results, I deduced some tasks/recommendation for aligning the workflows:
Status
Product
Mission
X
S1A GRDH IW SDV
Sentinel-1A
X
S1A GRDH IW SSH
Sentinel-1A
X
S1B GRDM EW SDV
Sentinel-1B
X
S1A GRDH IW SSH
Sentinel-1A
X
S1A SLC IW SDV
Sentinel-1A
X
S1C OCN IW SDV
Sentinel-1C
Y
S3 OLC EFR
Sentinel-3
X
S3 SL RBT
Sentinel-3
Y
S3 SL LST
Sentinel-3
Y
S3 OLC ERR
Sentinel-3
General recommendations:
harmonize the code to outsource functions used by all modes into a utils module
chunking
sharding
... everything else that can be simplified
Ideas for implementing S1:
remove bugs preventing running of the code (tbi) -> maybe alignment problem with cpm 3.0.0
create own S1 submodule
Ideas for implementing S3:
extend to more mode than OLCI -> SLSTR
extend functionalities of sharding and chunking
As these would be rather big changes, we would need to align who will implement which features.
Thanks @shollendEODC for the test matrix, and sorry for the late answer. The plan that @claxn proposed in #277 answers most of this, so I suggest we use this issue to track the product coverage, with one PR per product into main, as agreed there.
Sentinel-1 GRD failures. On main, S1 GRD goes through the generic pipeline with ground control points (groups=["measurements"], gcp_group="conditions/gcp"). Our tests cover this, but only with our fixtures. Could you share the errors (or a log) for the failing GRD products, and whether you ran them through the CPM driver with CPM 3.0.0? That tells us whether it is a CPM 3.0.0 product-structure change or a bug in the generic path.
Sentinel-1: fix GRD, then SLC and OCN, as their own submodule.
Sentinel-3: all OLCI and SLSTR products.
The optional "overviews" multiscale utility, and removing the reprojection under measurements for S1 GRD.
For each product PR, please include:
the product in the CPM routing (cpm/routing.py, by product:type), so eopf convert-geozarr picks it up
tests with a fixture of the product in the current test suite. Your approval-testing proposal is welcome as its own PR, as discussed in feat!: reintegrate cpm-geozarr into main #277.
Activity
shollendEODC commentedon Aug 25, 2026
@emmanuelmathot @d-v-b
would appreciate feedback/alignment on how to tackle it
emmanuelmathot commentedon Sep 28, 2026
Thanks @shollendEODC for the test matrix, and sorry for the late answer. The plan that @claxn proposed in #277 answers most of this, so I suggest we use this issue to track the product coverage, with one PR per product into
main, as agreed there.Where we are after #277 (0.12.0)
main--output-grid)ingest-s1commands (#216)Sentinel-1 GRD failures. On
main, S1 GRD goes through the generic pipeline with ground control points (groups=["measurements"],gcp_group="conditions/gcp"). Our tests cover this, but only with our fixtures. Could you share the errors (or a log) for the failing GRD products, and whether you ran them through the CPM driver with CPM 3.0.0? That tells us whether it is a CPM 3.0.0 product-structure change or a bug in the generic path.Order of work, following #277:
measurementsfor S1 GRD.For each product PR, please include:
cpm/routing.py, byproduct:type), soeopf convert-geozarrpicks it up