Skip to content

Add snyk severity threshold = High + run go mod tidy.#2531

Merged
andriisoldatenko merged 2 commits into
mainfrom
remove-depricated-deps
Jan 3, 2024
Merged

Add snyk severity threshold = High + run go mod tidy.#2531
andriisoldatenko merged 2 commits into
mainfrom
remove-depricated-deps

Conversation

@andriisoldatenko

@andriisoldatenko andriisoldatenko commented Jan 3, 2024

Copy link
Copy Markdown
Collaborator

Description

Add snyk severity threshold = High + run go mod tidy.

How can this be tested?

N/A

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly with a single label
  • I have read and understood the contribution guidelines

@andriisoldatenko
andriisoldatenko requested a review from a team as a code owner January 3, 2024 08:59
@andriisoldatenko andriisoldatenko changed the title After https://github.com/open-telemetry/opentelemetry-go/pull/4707 we should remove it. Remove deprecated dependency Jan 3, 2024
@andriisoldatenko andriisoldatenko changed the title Remove deprecated dependency [WIP] Remove deprecated dependency Jan 3, 2024
@andriisoldatenko
andriisoldatenko marked this pull request as draft January 3, 2024 09:01
@codecov-commenter

codecov-commenter commented Jan 3, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85e19e3) 64.56% compared to head (7345c52) 64.56%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2531   +/-   ##
=======================================
  Coverage   64.56%   64.56%           
=======================================
  Files         245      245           
  Lines       16178    16178           
=======================================
  Hits        10446    10446           
  Misses       4928     4928           
  Partials      804      804           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andriisoldatenko andriisoldatenko changed the title [WIP] Remove deprecated dependency Add snyk severity threshold = High + run go mod tidy. Jan 3, 2024
@andriisoldatenko
andriisoldatenko marked this pull request as ready for review January 3, 2024 09:16
@andriisoldatenko
andriisoldatenko merged commit a050434 into main Jan 3, 2024
@andriisoldatenko
andriisoldatenko deleted the remove-depricated-deps branch January 3, 2024 09:26
Comment thread .github/workflows/ci.yaml
Comment on lines +103 to +104
with:
args: --severity-threshold=high

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants