Skip to content

feat(searchBar): add forward delete functionality#185

Merged
QilongTang merged 2 commits intoDynamoDS:masterfrom
Enzo707:bugfix/DYN-5976/forward-delete-not-working
Aug 3, 2023
Merged

feat(searchBar): add forward delete functionality#185
QilongTang merged 2 commits intoDynamoDS:masterfrom
Enzo707:bugfix/DYN-5976/forward-delete-not-working

Conversation

@Enzo707
Copy link
Contributor

@Enzo707 Enzo707 commented Aug 2, 2023 •
edited
Loading

This PR implements forward delete functionality to searchBar input

Ref.: DYN-5976

forward-delete

FYI
@QilongTang
@RobertGlobant20

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@QilongTang
Copy link
Contributor

QilongTang commented Aug 2, 2023

hi @Enzo707 Can you check the code smells by sonarCloud scan?

@QilongTang QilongTang mentioned this pull request Aug 3, 2023
Merged
9 tasks
@Enzo707
Copy link
Contributor Author

Enzo707 commented Aug 3, 2023

hi @Enzo707 Can you check the code smells by sonarCloud scan?

@QilongTang I've removed a comment I left but there are 8 more issues reported long time ago, do you want me to fix them all?

@QilongTang
Copy link
Contributor

QilongTang commented Aug 3, 2023 •
edited
Loading

hi @Enzo707 Can you check the code smells by sonarCloud scan?

@QilongTang I've removed a comment I left but there are 8 more issues reported long time ago, do you want me to fix them all?

Gotcha, because I had the impression that the last merging PR has no code smells, so I post my last comment. But after checking I also realize that not all of them are brought by this PR. I will file a task for them (https://jira.autodesk.com/browse/DYN-6124) and merge this one for now

@QilongTang QilongTang merged commit 9de3f46 into DynamoDS:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Enzo707 @QilongTang