Skip to content

Send the category data to dynamo#116

Merged
ramramps merged 1 commit intomasterfrom
Remove-Misc-section
Feb 23, 2018
Merged

Send the category data to dynamo#116
ramramps merged 1 commit intomasterfrom
Remove-Misc-section

Conversation

@ramramps
Copy link
Collaborator

@ramramps ramramps commented Feb 23, 2018

In Dynamo Instrumentation, the Filter categories are collected in 1.3 version of Library.
In the new librarieJS this information is embedded inside the JS. This PR is to add an event which sends this Filter category information to the client (Dynamo in this case).

More specific detail:
Dynamo 1.3 has this for instrumentation

  StringBuilder strBuilder = new StringBuilder();
            foreach (var category in SearchCategories)
            {
                strBuilder.Append(category.Name);
                strBuilder.Append(" : ");
                if (category.IsSelected)
                {
                    strBuilder.Append("Selected");
                }
                else
                {
                    strBuilder.Append("Unselected");
                }
                strBuilder.Append(", ");
            }

            Analytics.LogPiiInfo("Filter-categories", strBuilder.ToString().Trim());

The above said category is in LibrareJS. It is the CategoryInfo class. So, returning that CategoryInfo to Dynamo, and it is easy to construct the data:checked, data:unchecked for instrumentation

@mjkkirschner @alfarok

@mjkkirschner
Copy link
Member

does this require updating the tests?

@ramramps
Copy link
Collaborator Author

ramramps commented Feb 23, 2018

what tests? there are no tests associated for this, because this is related to UI events.

@mjkkirschner
Copy link
Member

okay, thought it might matter for the enzyme tests - LGTM

@ramramps
Copy link
Collaborator Author

ramramps commented Feb 23, 2018

thanks @mjkkirschner I had the same thought first. but there are no tests for this. But the snapshot is updated. so the event cannot be missed.

@ramramps ramramps merged commit 7b2929b into master Feb 23, 2018
@QilongTang QilongTang deleted the Remove-Misc-section branch September 10, 2018 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants