Conversation
Member
|
does this require updating the tests? |
Collaborator
Author
|
what tests? there are no tests associated for this, because this is related to UI events. |
Member
|
okay, thought it might matter for the enzyme tests - LGTM |
Collaborator
Author
|
thanks @mjkkirschner I had the same thought first. but there are no tests for this. But the snapshot is updated. so the event cannot be missed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Dynamo Instrumentation, the Filter categories are collected in 1.3 version of Library.
In the new librarieJS this information is embedded inside the JS. This PR is to add an event which sends this Filter category information to the client (Dynamo in this case).
More specific detail:
Dynamo 1.3 has this for instrumentation
The above said
categoryis in LibrareJS. It is theCategoryInfoclass. So, returning thatCategoryInfoto Dynamo, and it is easy to construct thedata:checked, data:uncheckedfor instrumentation@mjkkirschner @alfarok