Remove icons from Geometry class sub-categories#108
Remove icons from Geometry class sub-categories#108alfarok merged 2 commits intoDynamoDS:masterfrom alfarok:master
Conversation
| if (this.props.data.itemType !== "group" && this.props.data.itemType !== "section") { | ||
| let itemType = this.props.data.itemType; | ||
| // If the element type is a section, group, or none an icon shouldn't be displayed | ||
| if (itemType !== "group" && itemType !== "section" && itemType !== "none") { |
There was a problem hiding this comment.
may be you should check the tests and see this is covered.
There was a problem hiding this comment.
@ramramps yes will do, the AC calls for a unit test
|
from ux perspective, looks good to me! thanks @alfarok |
|
@alfarok also please check the docs to see if the iconUrl is in the layout spec somewhere - if it is, should it now be removed? |
|
@mjkkirschner correct, they can be removed from the layout spec. If any are added or left in other places they should be simply ignored. I will do that in the Dynamo PR for the Geometry class. |
| onError={[Function]} | ||
| src="" | ||
| /> | ||
| <div |
There was a problem hiding this comment.
@mjkkirschner @ramramps these tags are no longer generated since the none element type is no longer adding icons so I have to update the snapshot to exclude them. If they were to get generated the test will now fail. You can see the tests that generate these 2 snaps here.
There was a problem hiding this comment.
Dynamo dynamically generates the data in the libraryUI so it is hard ensure all the required items are loaded in Librarie, for example if I wanted to verify icons are still generated for the nodes. I am not sure if this is adequate or if there is a better approach I could be taking here.
4 participants
Purpose
QNTM-2675
Supplemental Dynamo PR
The purpose of this PR is to remove the icons from the Geometry class sub-categories. The icons beside the Geometry categories is confusing as they look like nodes and not sub-categories.
There are several element types in library which determine the properties each layer has. The
noneelement type contains all expandable library items that are notcategoriesorgroups(essentially all the interim dropdowns). With this PR even if an icon url is specified it will be ignored so icons can now only be added at the top and bottom levels of the library hierarchy (categoriesand nodescreateactionquery)For more info on Element Types see the Librarie Docs
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner
FYIs
@Racel