Merged
Conversation
builds without errors
Contributor
|
Please update the Readme. thanks! |
now loads in all versions from the Extensions menu
Contributor
Author
|
Readme updated |
reddyashish
reviewed
Jun 28, 2024
| </PackageReference> | ||
| <PackageReference Include="DynamoVisualProgramming.Core" Version="3.2.1.5366"> | ||
| <ExcludeAssets>runtime</ExcludeAssets> | ||
| <IncludeAssets>compile; build; native; contentfiles; analyzers</IncludeAssets> |
Collaborator
There was a problem hiding this comment.
Any reason to explicitly add which assets to include here? Other projects don't do it.
Contributor
Author
There was a problem hiding this comment.
This one is in master. Given the brief I thought of keeping the same logic .
Will correct.
reddyashish
reviewed
Jun 28, 2024
reddyashish
reviewed
Jun 28, 2024
reddyashish
approved these changes
Jul 1, 2024
Contributor
|
@reddyashish Let's follow up to re-publish the package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per this tread: https://autodesk.slack.com/archives/CPJ5UQW0Z/p1718630160699509
DynamoVisualProgrammingpackages are updated to the latest versionNUnitis replaced withNUnit3(+ NUnit3TestAdapter)*.csfiles to avoid duplicate compile item errorsAssemblyInfo.csto avoid duplicate attributes*.xamlfiles to avoid duplicate page item errorsRequiresSTAis replaced withApartment(ApartmentState.STA)in unit tests