TuneUp menu item should be under Extensions menu.#39
TuneUp menu item should be under Extensions menu.#39reddyashish merged 3 commits intoDynamoDS:masterfrom
Conversation
TuneUp/TuneUpViewExtension.cs
Outdated
|
|
||
| }; | ||
| p.AddMenuItem(MenuBarType.View, TuneUpMenuItem); | ||
| p.AddExtensionMenuItem(TuneUpMenuItem); |
There was a problem hiding this comment.
hmm can you test loading this view ex in legacy version of Dynamo? I think part of the AC is that if user download newer version of TuneUp in older version of Dynamo e.g. 2.6.1, Dynamo should not crash when loading TuneUp. This code may crash in older version of Dynamo, we may need to wrap this code in try catch and fall back to the older version of API
There was a problem hiding this comment.
Address this issue in the latest commit.
|
@QilongTang After discussing with @mjkkirschner, found out that by using Dynamic ViewLoadedParams object we can call the respective API's. Tested it on latest master as well as older versions of Dynamo. Latest master: 2.11 and older versions of Dynamo: |
| public void Loaded(ViewLoadedParams p) | ||
| public override void Loaded(ViewLoadedParams p) | ||
| { | ||
| dynamic dp = (dynamic) p; |
There was a problem hiding this comment.
Can you add comments to this?
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
One comment then LGTM
|
Addressed all comments. Merging this. |
2 participants
When TuneUp package is installed, "Show TuneUp" menu item should be present under the Extensions menu.
To use the AddExtensionMenuItem API from ViewLoadedParams class, the DynamoCore references are pointed to the Dynamo 2.12 version. The TargetFrameworkVersion is also set to v4.8.