Set DynamoView as Owner of TuneUp window#33
Merged
mmisol merged 1 commit intoDynamoDS:masterfrom Apr 9, 2020
Merged
Conversation
This prevents leaving Dynamo running as a zombie process after closing.
Contributor
|
Looks Good. However, seems this fix will need updated Dynamo to work together. Is there a way to also save current users? |
Contributor
Author
|
Actually no, this does not require any changes in Dynamo. It works as long as we set the owner properly in either of the two places. |
Contributor
|
@mmisol Thanks! Then LGTM |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents leaving Dynamo running as a zombie process after closing.