DYN-5268-SplashScreen-NotLoadingFix#13
Merged
QilongTang merged 2 commits intoDynamoDS:masterfrom Oct 20, 2022
Merged
Conversation
When trying to load the splash screen in Dynamo was showing a blank screen, the problem was that due that the javascript code is inserted on runtime when loading the html page in WebView2 the javascript code was not finding the element "root", once I moved the root <div> above the <script> tag started to work correctly.
QilongTang
reviewed
Oct 20, 2022
| </script> | ||
| <script>mainJs</script> | ||
| <div id="root"></div> | ||
| <script>mainJs</script> |
Contributor
There was a problem hiding this comment.
oh I did not know it would be as simple as this since I checked this file as well.. why do we need to move this line?
Contributor
Author
There was a problem hiding this comment.
@QilongTang the mainJS text is replaced on runtime by .NET when loading in WebView2, so in runtime React (js) is trying to find the "root" element inside the html but is not found due that was declared after the <script> tag so just moving the root element one level up will fix the problem.
This is the React code trying to find the root:

Contributor
Author
Contributor
Author
Contributor
|
Hi @RobertGlobant20 Please also increase the version of this package |
Updating the package version
Contributor
Author
|
QilongTang
approved these changes
Oct 20, 2022
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Purpose
Fix for loading the SplashScreen in Dynamo at startup
When trying to load the splash screen in Dynamo was showing a blank screen, the problem was that due that the javascript code is inserted on runtime when loading the html page in WebView2 the javascript code was not finding the element "root", once I moved the root
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fix for loading the SplashScreen in Dynamo at startup
Reviewers
@QilongTang
FYIs