Merged
Conversation
Member
|
yeah we can do that - or the simplest alternative may be to push your custom build of greg to a custom dynamo branch and reference it as a dll directly. |
8 tasks
Contributor
Author
|
@reddyashish @zeusongit @mjkkirschner The customer support suggests merging this and validate this ourselves. I suppose once I merge this, a newer version of Greg will be published and I will update my PR in Dynamo side to integrate that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Enable NTLM authenticator for https://jira.autodesk.com/browse/DYN-2087.
Given we will need a branch build to pass to support, @mjkkirschner do you think we can publish Greg with this change on nuget and then branch Dynamo using that or there is a diff way
Declarations
Check these if you believe they are true
Reviewers
@mjkkirschner
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of