[DYN-7330] Add a button to show Sample Graph folder and Sample Dataset#28
Merged
reddyashish merged 6 commits intoDynamoDS:masterfrom Sep 3, 2024
Merged
[DYN-7330] Add a button to show Sample Graph folder and Sample Dataset#28reddyashish merged 6 commits intoDynamoDS:masterfrom
reddyashish merged 6 commits intoDynamoDS:masterfrom
Conversation
9 tasks
text changed from "Show in the folder" to "Open file location"
QilongTang
reviewed
Aug 30, 2024
| "samples.showsamples.text": "Zobrazit vzorky ve složce", | ||
| "samples.showsamples.text": "Otevřít umístění souboru", | ||
| "samples.showsamples.files.text": "Grafy", | ||
| "samples.showsamples.datasets.text": "Datové sady", |
Collaborator
There was a problem hiding this comment.
Hi @ivaylo-matov Where do these localized resources come from? We have a dedicated localization team to handle that so if these are from you, I need to ask them to validate
Contributor
Author
There was a problem hiding this comment.
Hey @QilongTang ! Yes, please ask the team to validate them. I though it would be nice to add them as placeholders. Thanks.
QilongTang
approved these changes
Aug 30, 2024
reddyashish
approved these changes
Sep 3, 2024
Collaborator
|
Merging this to get the dynamo build PR running. Once localization team verifies it, we will do a followup if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
PR to address https://jira.autodesk.com/browse/DYN-7330.
Adds a button for a dropdown to allow users to find Sample Graph folder and Sample Dataset. The button replaces the current "Show samples in folder button"
Goes along with : DynamoDS/Dynamo#15449
Hope that's okay 🤞
Reviewers
@dnenov
@reddyashish
FYIs
@Amoursol