Skip to content

Dyn-6750-new-open-update#14

Merged
QilongTang merged 2 commits intomasterfrom
DYN-6750-new-open-update
May 1, 2024
Merged

Dyn-6750-new-open-update#14
QilongTang merged 2 commits intomasterfrom
DYN-6750-new-open-update

Conversation

@dnenov
Copy link
Collaborator

@dnenov dnenov commented Apr 26, 2024

Purpose

This PR addresses a jira request for improvement of the HomePage: As a Dynamo user, I would like to have New and Open buttons in app home to have default actions https://jira.autodesk.com/browse/DYN-6750.

By default, clicking on the button should perform the default action.
New -> New workspace
Open -> Open File

Only the dropdown should show other options
New ...

  • Workspace

Custom Node
Open ...

Open File
Open Template
Backup Locations
Also can shit New to the top top?

UI Changes

DynamoSandbox_qkOXGy4Uo6

Changes

  • now separates the 'button' from the 'drop-down' functionality of the 'Open' and 'New' HomePage buttons.
  • visual rehaul with @Jingyi-Wen
  • version bump

Reviewer

@QilongTang
@Amoursol

@QilongTang
Copy link
Collaborator

QilongTang commented Apr 30, 2024

This one becomes hard to review because it contains changes in the other preferences PR..

@dnenov
Copy link
Collaborator Author

dnenov commented Apr 30, 2024

This one becomes hard to review because it contains changes in the other preferences PR..

Understood, Aaron - should I try to restructure it and remove the Preferences changes .. or wait to merge the Preferences PR and pull the latest main branch maybe?

@QilongTang
Copy link
Collaborator

QilongTang commented May 1, 2024

This one becomes hard to review because it contains changes in the other preferences PR..

Understood, Aaron - should I try to restructure it and remove the Preferences changes .. or wait to merge the Preferences PR and pull the latest main branch maybe?

I would remove the preferences changes and keep it clean because this could land earlier than the other sets of PR

@dnenov dnenov force-pushed the DYN-6750-new-open-update branch from 6106599 to d90207a Compare May 1, 2024 05:49
@dnenov
Copy link
Collaborator Author

dnenov commented May 1, 2024

This one becomes hard to review because it contains changes in the other preferences PR..

Understood, Aaron - should I try to restructure it and remove the Preferences changes .. or wait to merge the Preferences PR and pull the latest main branch maybe?

I would remove the preferences changes and keep it clean because this could land earlier than the other sets of PR

Done, @QilongTang! Thanks for the pointers!!

@QilongTang QilongTang merged commit 5b6b90b into master May 1, 2024
@QilongTang QilongTang deleted the DYN-6750-new-open-update branch May 1, 2024 14:32
@QilongTang QilongTang mentioned this pull request May 1, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dnenov @QilongTang