Change to use public getter instead of private member#9966
Merged
QilongTang merged 1 commit intoRC2.4.0_masterfrom Sep 9, 2019
Merged
Change to use public getter instead of private member#9966QilongTang merged 1 commit intoRC2.4.0_masterfrom
QilongTang merged 1 commit intoRC2.4.0_masterfrom
Conversation
Member
|
@QilongTang thanks - is it difficult to add a test to assert this function does not throw? |
Contributor
Author
|
@mjkkirschner Unfortunately, publishing current workspace will always throw an exception no matter what. So assertion test does not help. |
QilongTang
added a commit
that referenced
this pull request
Sep 9, 2019
7 tasks
QilongTang
added a commit
that referenced
this pull request
Sep 9, 2019
Contributor
|
@QilongTang sorry that was me that made the change recently: ef55f1b#diff-87708e28021df7b325448575f92c8e69R189 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
Some code refactor happened and removed the setting of private member. This PR fix the regression that publish current workspace command does not return anything.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of