DYN-2101 Installing ampersand package crashes Dynamo while the graph is open#9957
Merged
mjkkirschner merged 9 commits intoDynamoDS:masterfrom Sep 3, 2019
Merged
DYN-2101 Installing ampersand package crashes Dynamo while the graph is open#9957mjkkirschner merged 9 commits intoDynamoDS:masterfrom
mjkkirschner merged 9 commits intoDynamoDS:masterfrom
Conversation
Merged
7 tasks
Member
|
LGTM |
7 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is to fix the crash exception reported in the task: https://jira.autodesk.com/browse/DYN-2101
In short, when a new package is being loaded into Dynamo(while the graph is open in automatic mode), the VM is reinitialized and reloads all the libraries(including the core one's) into the VM. So when the node's are resolved, execution run's are triggered asynchronously. This causes a thread timing issue as the post execution run steps are called after the VM is reset and the DSExecutable object is lost during the execution run. To avoid this case, we have added a flag to check if the packages are being loaded and skip those initial run's as a final run is anyways triggered after the reloading of libraries is completed.
In order to make sure, we do not have any new regressions, we plan to merge this to master first before merging into the RC_2.4 branch.
For testing: we have a UI automation test that @mjkkirschner added https://github.com/DynamoDS/DynamoUIAutomation/pull/155
TODO:
We plan to re-evaluate this whole workflow in the future.
Task: https://jira.autodesk.com/browse/DYN-2120
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner @aparajit-pratap @QilongTang