Remove Down Vote Button and Obsolete UI command#9950
Merged
QilongTang merged 2 commits intomasterfrom Sep 4, 2019
Merged
Conversation
| } | ||
|
|
||
| [Obsolete("This API will no longer decrease package votes and will be removed in Dynamo 3.0")] | ||
| public void Downvote() |
Member
There was a problem hiding this comment.
if someone calls this method - it should do nothing right? Will the continuation ever get called?
Contributor
Author
There was a problem hiding this comment.
Yes, since the handler of the DownvoteRequested event is removed, the call will do nothing and return nothing
Contributor
Author
|
Self CI passed |
Member
|
@QilongTang LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
DYN-1990
As a Dynamo dev, I want to clean up package down vote info to push positive reinforcement.
Before:

After:

Declarations
Check these if you believe they are true
*.resxfilesRunning Self CI
Reviewers
@DynamoDS/dynamo
FYIs
@Dewb @johnpierson @Amoursol