Revert "Revert ASM Loading changes"#9937
Merged
mjkkirschner merged 1 commit intoRC2.4.0_masterfrom Aug 26, 2019
Merged
Conversation
This reverts commit 508896f.
Contributor
|
Do we want to address the slowdown in 2.4? If not, are we okay with this change going in and we accept some slowdown? |
Member
Author
|
@aparajit-pratap - after we see how much slowdown this change introduces relative to the times we are getting for 2.4 right now - lets discuss. |
mjkkirschner
added a commit
that referenced
this pull request
Aug 29, 2019
mjkkirschner
added a commit
that referenced
this pull request
Aug 29, 2019
mjkkirschner
added a commit
that referenced
this pull request
Aug 30, 2019
mjkkirschner
added a commit
that referenced
this pull request
Aug 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #9932
@aparajit-pratap - now that we have a good build, but know this does have some associated slowdown at startup time- I'd like to get this back into the same state as master before we discuss what nexts steps ((if any)) should be to address the slowdown -
can we merge this in to get 2.4 and master back in sync?