update dev view UI when package installed.#9915
update dev view UI when package installed.#9915mjkkirschner merged 2 commits intoDynamoDS:masterfrom
Conversation
set package loader to update dep UI add this outisde the view to make it clear this is intended to be a singleton view
mjkkirschner
changed the title
| using Dynamo.Wpf.Extensions; | ||
| using System; | ||
| using System.Linq; | ||
| using System.Windows.Controls; |
There was a problem hiding this comment.
https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards#usings I think we agreed from the recent conversation
| // as we may have installed a missing package. | ||
| pmExtension.PackageLoader.PackgeLoaded += (package) => | ||
| { | ||
| DependencyView.DependencyRegen(viewLoadedParams.CurrentWorkspaceModel as WorkspaceModel); |
There was a problem hiding this comment.
I guess this way, if a package is downloaded using the package manager interface, the view extension here will pick up that change as well? Does that cover all the cases in Dynamo?
There was a problem hiding this comment.
@QilongTang it doesn't cover other dependency types - I'm also not sure if it covers packages being uninstalled - do you want me to add this same handler for package removal? (if that event exists?)
There was a problem hiding this comment.
it does exist pmExtension.PackageLoader.PackageRemoved
There was a problem hiding this comment.
a bit hesitant to get into packageRemoval now and how it relates to package's being in a pending uninstall state.
Would like to defer adding this handler until later or atleast splitting this into two PRs.
There was a problem hiding this comment.
Let's leave the uninstall case for now, I would like to give it some testing first
|
|
||
|
|
||
| [Obsolete("This method is not implemented and will be removed.")] | ||
| public void Ready(ReadyParams readyParams) |
|
Looks good with one question. |
|
@QilongTang flipped the usings - and one thought on the question about dynamo package cases - |
|
@mjkkirschner I think it is good for now. |
* get rid of properties that were not set set package loader to update dep UI add this outisde the view to make it clear this is intended to be a singleton view * flipped usings (cherry picked from commit 9243c17)
* DYN-1874: I want to download missing graph package dependencies easily (#9854) * Add IPackageInfo interface * Add IPackageInfo interface * Add PackageManagerClient API to intiate download and install of a package * Add download button to test package download * Add IPackageInfo interface * Use PD state * Fix comment * Refactor Dependency Viewer UI * Rename ExecutePackage -> ExecutePackageDownload * Add PackageManagerClientViewModel to ViewLoadedParams * Add IPackageDownloader to LoadedViewParams * Move messages to resource file * Add state-based messages * Font size * Keep ReferenceType and INodeLibraryDepInfo internal * IPackageDownloader.cs -> IPackageInstaller.cs * IPackageInstaller comments * Move details message to resx * Fix resource conflict * Check terms of use acceptance before downloading package * Embed icons in resources.resx * Remove raw resources * Add summary to public class * Add summaries for PackageDependencyRow members (cherry picked from commit 8ca9d0f) * merge conflict assemblyInfo * remove unnecessary API * update dev view UI when package installed. (#9915) * get rid of properties that were not set set package loader to update dep UI add this outisde the view to make it clear this is intended to be a singleton view * flipped usings (cherry picked from commit 9243c17) * review comments * sneaky equals
2 participants
set package loader to update dep UI
add this outisde the view to make it clear this is intended to be a singleton view
get rid of properties that were not set
Purpose
update dep UI when package is loaded to catch new installations.
also gets rid of ready params from extension - those are only set on model extensions...
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@scottmitchell