DYN-2002 Localize the node description tooltip.#9907
Merged
reddyashish merged 3 commits intoDynamoDS:masterfrom Aug 16, 2019
Merged
DYN-2002 Localize the node description tooltip.#9907reddyashish merged 3 commits intoDynamoDS:masterfrom
reddyashish merged 3 commits intoDynamoDS:masterfrom
Conversation
Member
|
@reddyashish nice, can we also add a test for this? |
QilongTang
reviewed
Aug 14, 2019
Collaborator
Author
|
@mjkkirschner I have added the test. There are no failures on self-service but do you still think any of the existing tests have to be updated? |
reddyashish
added a commit
to reddyashish/Dynamo
that referenced
this pull request
Aug 16, 2019
* DYN2002 * Adding comments. * Adding test (cherry picked from commit 731aeb6)
7 tasks
reddyashish
added a commit
that referenced
this pull request
Aug 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is in reference to this task: https://jira.autodesk.com/browse/DYN-2002.
In short after this fix, the description tooltip (for the nodes in the workspace) will be converted to the localized language. We will still be serializing this property but when deserializing we do not read this value from the JSON file. The value will be picked up from node's xml config and will be converted to the localized language.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner @QilongTang @aparajit-pratap