Fix localization for Spanish Civil 3D#9876
Merged
QilongTang merged 2 commits intoDynamoDS:RC2.4.0_masterfrom Aug 5, 2019
angelowang:RC2.4.0_master
Merged
Fix localization for Spanish Civil 3D#9876QilongTang merged 2 commits intoDynamoDS:RC2.4.0_masterfrom angelowang:RC2.4.0_master
QilongTang merged 2 commits intoDynamoDS:RC2.4.0_masterfrom
angelowang:RC2.4.0_master
Conversation
In AutoCAD/Civil3D, `CurrentUICulture.ToString()` will return traditional `es-ES_tradnl`, instead of plain `es-ES`. This will fail the finding of xml document later. This change uses `CurrentUICulture.Name` instead. From MS DOC for `CultureInfo.Name`: > Gets the culture name in the format languagecode2-country/regioncode2.
Contributor
|
@angelowang Thank you, LGTM, will merge and run tests on it |
QilongTang
pushed a commit
that referenced
this pull request
Aug 5, 2019
* Fix tooltip for Spanish Civil 3D In AutoCAD/Civil3D, `CurrentUICulture.ToString()` will return traditional `es-ES_tradnl`, instead of plain `es-ES`. This will fail the finding of xml document later. This change uses `CurrentUICulture.Name` instead. From MS DOC for `CultureInfo.Name`: > Gets the culture name in the format languagecode2-country/regioncode2. * More fix for samples and gallery
7 tasks
QilongTang
added a commit
that referenced
this pull request
Aug 5, 2019
* Fix tooltip for Spanish Civil 3D In AutoCAD/Civil3D, `CurrentUICulture.ToString()` will return traditional `es-ES_tradnl`, instead of plain `es-ES`. This will fail the finding of xml document later. This change uses `CurrentUICulture.Name` instead. From MS DOC for `CultureInfo.Name`: > Gets the culture name in the format languagecode2-country/regioncode2. * More fix for samples and gallery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In AutoCAD/Civil3D,
CurrentUICulture.ToString()will return traditionales-ES_tradnl,instead of plain
es-ES. This will fail the finding of xml document, gallery, and sample folders later.This change uses
CurrentUICulture.Nameinstead.From MS DOC for
CultureInfo.Name:Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
(FILL ME IN) This section describes why this PR is here. Usually it would include a reference
to the tracking task that it is part or all of the solution for.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo
FYIs