Publish Package with Host Multi-Selection#9850
Merged
QilongTang merged 9 commits intomasterfrom Jul 30, 2019
Merged
Conversation
src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
Outdated
Show resolved
Hide resolved
Member
|
@QilongTang the JSON here looks odd, why is the same dll added twice as a |
Contributor
Author
|
@mjkkirschner I have no idea, was just using a random dll to test serialization |
Member
|
@QilongTang can you confirm that before your change the same node libraries json would have been generated... and this is not a regression caused by this PR? |
Contributor
Author
|
@mjkkirschner I can't reproduce it before or after my changes again. |
Contributor
Author
|
Running self CI now |
Contributor
Author
Member
|
@QilongTang whats the failure stack on ci? |
Contributor
Author
|
@mjkkirschner I am running the self CI again now Figured this out, this does not fail in VS 2019 but a null check for setter is apparently needed for lower version of C# |
Collaborator
|
Looks good to me. |
src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Addressed all comments, and all self CI passed now. Merging once all checks passed |
QilongTang
added a commit
that referenced
this pull request
Jul 30, 2019
* Initial Commit * Add hosts selections * Add the multi selection * Multiple Host Selection Display * Correct Host Dependencies in Json for publishing and download * Code Clean up * More Cleanup and Comments * Bug fixing - publish version * More comments and regression
7 tasks
QilongTang
added a commit
that referenced
this pull request
Jul 30, 2019
* Initial Commit * Add hosts selections * Add the multi selection * Multiple Host Selection Display * Correct Host Dependencies in Json for publishing and download * Code Clean up * More Cleanup and Comments * Bug fixing - publish version * More comments and regression
mjkkirschner
pushed a commit
that referenced
this pull request
Aug 3, 2019
* Initial Commit * Add hosts selections * Add the multi selection * Multiple Host Selection Display * Correct Host Dependencies in Json for publishing and download * Code Clean up * More Cleanup and Comments * Bug fixing - publish version * More comments and regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
This PR is about adding the host multi-selection and part of the regular package publishing workflow.
What I have tested:
canSubmitcheck will not mandate itTODO:
- [ ] Add publish check for host dependenciesWhat it looks now

The
pkg.jsongenerated when publishing the package locally{ "license": "", "file_hash": null, "name": "Test", "version": "1.0.2", "description": "TestTestTestTest", "group": "", "keywords": null, "dependencies": [], "host_dependencies": [ "Revit", "Civil 3D" ], "contents": "", "engine_version": "2.4.0.5716", "engine": "dynamo", "engine_metadata": "", "site_url": "", "repository_url": "", "contains_binaries": true, "node_libraries": [ "Analysis, Version=2.3.0.4293, Culture=neutral, PublicKeyToken=null", "Analysis, Version=2.3.0.4293, Culture=neutral, PublicKeyToken=null" ] }Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo
FYIs
@Amoursol