DYN-1999 Adding a section for users to provide feedback.#9822
DYN-1999 Adding a section for users to provide feedback.#9822reddyashish merged 7 commits intoDynamoDS:masterfrom
Conversation
|
One comment then LGTM. Also can we get rid of the white board around extension view in the right panel? Looking a bit strange and inconsistent with the left one |
src/PackageDependencyViewExtension/PackageDependencyView.xaml.cs
Outdated
Show resolved
Hide resolved
|
|
||
| private WorkspaceModel currentWorkspace; | ||
|
|
||
| private String FeedbackLink = "https://forum.dynamobim.com/t/call-for-feedback-on-dynamo-graph-package-dependency-display/37229"; |
There was a problem hiding this comment.
@reddyashish I think this should just be:
https://github.com/DynamoDS/Dynamo/issues in general - @QilongTang what do you think? I think your forum post is auto closing in a few days?
There was a problem hiding this comment.
I have removed the auto closing last night. Also I think 3rd party extension owner ship wise I would prefer forum post if you would like to set an example. I understand that because our team owns this, this should lives in Dynamo issues, maybe we could message that differently
|
@Amoursol FYI |
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
A few comments then Good for me
src/PackageDependencyViewExtension/PackageDependencyView.xaml.cs
Outdated
Show resolved
Hide resolved
Adding to resource and configuration files.
|
@Amoursol Is the background color fine? |
|
@reddyashish We should be very careful of introducing another colour to the Dynamo Palette without good reason. Can we try black text on the original blue please? |
|
After talking to Sol, since we have all the text in dynamo in White color, we wanted to keep that consistent. For the background color, we are using the same color that appears on the border of a node when it is selected in the workspace.
|
|
Addressed all the comments. If this looks good, we can merge it. |
|
Merging this. Will cherry-pick this to 2.3 also |
* DYN-1999 Adding a section for users to provide feedback. * Removing extra styling * Extra spacing * Addressing comments * Addressing comments Adding to resource and configuration files. * Setting grid row value to zero. * Changing background color (cherry picked from commit 8202644)
* DYN-1999 Adding a section for users to provide feedback. * Removing extra styling * Extra spacing * Addressing comments * Addressing comments Adding to resource and configuration files. * Setting grid row value to zero. * Changing background color (cherry picked from commit 8202644)
* DYN-1999 Adding a section for users to provide feedback. * Removing extra styling * Extra spacing * Addressing comments * Addressing comments Adding to resource and configuration files. * Setting grid row value to zero. * Changing background color
4 participants
Purpose
This PR is to add a footer section to get feedback from the user regarding the package dependency view extension feature.
JIRA: https://jira.autodesk.com/browse/DYN-1999
The LightBlue color for the section was making it hard to read the text inside, so I used another shade of blue. Let me know your thoughts on these.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo