Conversation
QilongTang
changed the title
|
Not sure why the AppVeyor build failed, the following code should build fine but throwing errors on that VM. public List<FilterEntry> HostFilter
{
get => hostFilter;
set
{
hostFilter = value;
RaisePropertyChanged("HostFilter");
}
} |
|
It turns out the code above is in a newer .Net comes with VS 2019 which our build vm does not support yet, so I updated to use the traditional way. |
|
@QilongTang if you want to use that you'll need to swtich to using msbuild 15 I think on the build machine. Our docker image should support this already, but I am not sure about the main pipeline (and very likely not self serve) |
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs
Outdated
Show resolved
Hide resolved
| <Reference Include="Greg, Version=1.0.6176.18754, Culture=neutral, processorArchitecture=MSIL"> | ||
| <HintPath>..\packages\Greg.1.0.6176.18754\lib\net45\Greg.dll</HintPath> | ||
| <Reference Include="Greg, Version=1.2.7121.21318, Culture=neutral, processorArchitecture=MSIL"> | ||
| <HintPath>..\packages\Greg.1.2.7121.21318\lib\net45\Greg.dll</HintPath> |
There was a problem hiding this comment.
we should delete this project.
There was a problem hiding this comment.
Totally, is this the js version pm client?
There was a problem hiding this comment.
yes, we can remove this at any time.
There was a problem hiding this comment.
I see, seems it is in the repo but not part of the solution, so little risk
| <Button Width="Auto" | ||
| Grid.Column="2" | ||
| Click="OnFilterButtonClicked" | ||
| fa:Awesome.Content="Filter" |
There was a problem hiding this comment.
What do you think of also adding a tooltip here? to the filter icon if it doesn't exist already?
There was a problem hiding this comment.
I can apply the same tooltip which I just added also to the context options, but the button I think need some different messaging?
|
@mjkkirschner Let me know if you prefer more changes on this one. Otherwise trying to get a real build by demo tomorrow |
|
@QilongTang LGTM - I had some alternative tooltip text for you to consider first though. |
* Intial Commit * Add Context Menu UI binding * Add Calls to get supported hosts * Some more code * Clean Up * Clean up * Package dependency Search * Add unfilter support * Code Clean up and more elegent filter code * Update the host dependencies getter * Add package search element display of hosts * Add style changes including fonts, vertical alignment, tooltip * try to fix self CI * Add unit test * Remove the test added * Address comments * Add more tooltips * Update Tooltips
3 participants
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
This PR adds a host filter right next to the traditional package sorting option. I will look at illustrating the host dependencies on each package entry as well but the mock up data is not working for me. Regardless of that, the filter and package filtering code is done. Currently it is a global setting which will affect searched results and sorted results or any combination.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo
FYIs
@gregmarr