Cherry-pick Refactor PackageDependencies property (#9803)#9819
Merged
scottmitchell merged 1 commit intoDynamoDS:RC2.3.0_masterfrom Jun 28, 2019
Merged
Cherry-pick Refactor PackageDependencies property (#9803)#9819scottmitchell merged 1 commit intoDynamoDS:RC2.3.0_masterfrom
scottmitchell merged 1 commit intoDynamoDS:RC2.3.0_masterfrom
Conversation
* Refactor PackageDependencies property * Add test to verify multiple packages not listed as dependencies for one node * Keep original package dependency by default and add API to void original package dependency * Add comment * Move helper methods out of properties region * Fix IsLoaded logic * Update test .dyn to avoid serialization test failures * Exclude new dyn from serialization tests * Use preexisting method to exclude test dyn from serialization tests
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor PackageDependencies property
Add test to verify multiple packages not listed as dependencies for one node
Keep original package dependency by default and add API to void original package dependency
Add comment
Move helper methods out of properties region
Fix IsLoaded logic
Update test .dyn to avoid serialization test failures
Exclude new dyn from serialization tests
Use preexisting method to exclude test dyn from serialization tests
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
(FILL ME IN) This section describes why this PR is here. Usually it would include a reference
to the tracking task that it is part or all of the solution for.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of