DYN-1662 Follow Up: Return copy of PackageDependencyInfo instead of reference#9773
Merged
scottmitchell merged 2 commits intoDynamoDS:masterfrom Jun 5, 2019
Merged
DYN-1662 Follow Up: Return copy of PackageDependencyInfo instead of reference#9773scottmitchell merged 2 commits intoDynamoDS:masterfrom
scottmitchell merged 2 commits intoDynamoDS:masterfrom
Conversation
Member
|
LGTM |
Merged
19 tasks
mjkkirschner
pushed a commit
that referenced
this pull request
Aug 3, 2019
…eference (#9773) * Return copy of PackageDependencyInfo instead of reference. * Add comments and TODOs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR follows up on #9723. It fixes an issue where the IDs of deleted nodes would still be serialized inside of
PackageDependencies.Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner