Cherry-picking the missing PR for languages changes into 2.0.3#9760
Merged
reddyashish merged 1 commit intoDynamoDS:RC2.0.3_masterfrom Jun 1, 2019
Merged
Conversation
Member
|
I think there is already a test, but it didn't exist in 2.0.2 timeframe. Does this fix the revit issue? |
Collaborator
Author
|
yes, the failing revit test is fine after this. Will have to trigger that test job again |
Collaborator
Author
|
All the tests passed on self-serve CI. Merging this and will run the revit tests after the build is posted. |
Contributor
|
Thanks @reddyashish |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is to cherry-pick #9431 into 2.0.3. This was missed during the previous cherry-picking of language changes into 2.0.3 (#9730).
This was necessary as the list.cartesian node was giving incorrect values. Refer to the snapshot below.
After this fix, the output of list.cartesian node returns the actual values instead of null values.
I think we need to add this case to our test coverage. I will try to add one in this PR, else I will create a TODO for this.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@aparajit-pratap @mjkkirschner