Move initial setup of IsAnalyticsReportingApproved to PreferenceSettings constructor#9666
Merged
QilongTang merged 1 commit intoDynamoDS:masterfrom May 29, 2019
Merged
Conversation
Contributor
|
Contributor
Author
|
@QilongTang I didn't change migration behavior. Analytics term of use window would still appear during first run of every new version of Dynamo. I just removed hardcoded value set, because we need to set it as "false" by default if user has no previous preferences. The window, however, will show value of IsAnalyticsReportingApproved from migrated preferences of previous Dynamo version instead of always "true" |
Contributor
|
@DmytroMuravskyi Thanks! I verified locally and behavior change looks good to our team. However, unit tests are missing from this PR. I will add in a different PR. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Alias integration needs control over analytics tick on the first run. To achieve this I moved the variable initialization from CheckIsFirstRun to PreferenceSettings constructor. This allows override IsAnalyticsReportingApproved before creating DynamoCore if needed. The only change to default Dynamo behavior I see is that now IsAnalyticsReportingApproved option can now migrate from previous Dynamo version instead of always being "true" during the first run. Please inform me what is the wanted behavior.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner