Skip to content

Fix return keyword as it appears in code completion#9649

Merged
aparajit-pratap merged 1 commit intoDynamoDS:masterfrom
aparajit-pratap:fixReturn
Apr 11, 2019
Merged

Fix return keyword as it appears in code completion#9649
aparajit-pratap merged 1 commit intoDynamoDS:masterfrom
aparajit-pratap:fixReturn

Conversation

@aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Apr 11, 2019

Purpose

Fix return keyword as it appears in code completion.

Before:
image

After:
image

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • [] Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@mjkkirschner
@QilongTang

@QilongTang
Copy link
Contributor

QilongTang commented Apr 11, 2019

This is impressive, how did you find the issue? Is there a github issue on this or from your own testing?

@aparajit-pratap
Copy link
Contributor Author

aparajit-pratap commented Apr 11, 2019

This is impressive, how did you find the issue? Is there a github issue on this or from your own testing?

It's been around for ages, I found it very annoying.

@QilongTang
Copy link
Contributor

QilongTang commented Apr 11, 2019

@aparajit-pratap LGTM off course. But was curious why it was "return_reserved"

@aparajit-pratap
Copy link
Contributor Author

aparajit-pratap commented Apr 11, 2019

@QilongTang the return_reserved was named that way as return is a reserved keyword in DesignScript and before autocomplete in code block nodes we weren't exposing it to the user so it didn't matter. I don't think it was updated after the introduction of autocomplete but I could be wrong.

@aparajit-pratap aparajit-pratap merged commit a6e19cf into DynamoDS:master Apr 11, 2019
@aparajit-pratap aparajit-pratap deleted the fixReturn branch April 11, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aparajit-pratap @QilongTang