DYN-1706: Graphs with Automatic Run Type honor RunEnabled settings#9641
Merged
QilongTang merged 8 commits intoDynamoDS:masterfrom Apr 12, 2019
Merged
DYN-1706: Graphs with Automatic Run Type honor RunEnabled settings#9641QilongTang merged 8 commits intoDynamoDS:masterfrom
QilongTang merged 8 commits intoDynamoDS:masterfrom
Conversation
Member
|
@reddyashish this is kind of worrisome: did you check that this issue that @benglin was working on does not reoccur after your change? |
Collaborator
Author
|
Yes, this was just a draft and let's discuss about this issue in the standup. |
Contributor
|
@reddyashish @mjkkirschner I think checking the node value in this case is not easy unless I am missing pieces. I tried myself and with @reddyashish together, node value is not guaranteed to be accurate, same with var openPath = Path.Combine(GetTestDirectory(ExecutingDirectory), @"core\RunSettings.dyn");
ViewModel.OpenCommand.Execute(openPath);
var ws = Model.CurrentWorkspace as HomeWorkspaceModel;
AssertEvaluationCount(ws, 0);
ws.RequestRun();
// Still in Manual mode so will not run
AssertEvaluationCount(ws, 0);
ws.RunSettings.RunType = RunType.Automatic;
// Setting to automatic will triger run right away
AssertEvaluationCount(ws, 1);
ws.RunSettings.RunEnabled = false;
ws.RequestRun();
// This should not run
AssertEvaluationCount(ws, 1);
ws.RunSettings.RunEnabled = true;
ws.RequestRun();
// This should run
AssertEvaluationCount(ws, 2); |
angelowang
reviewed
Apr 11, 2019
angelowang
reviewed
Apr 11, 2019
QilongTang
reviewed
Apr 11, 2019
angelowang
approved these changes
Apr 11, 2019
Contributor
|
LGTM |
mjkkirschner
approved these changes
Apr 12, 2019
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is to make sure that the graphs that are set to automatic run type honor the RunEnabled settings. The RunEnabled flag is checked in the RequestRun function as well as in the ResetEngine function.
JIRA: https://jira.autodesk.com/browse/DYN-1706
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang @mjkkirschner @aparajit-pratap