Merged
Conversation
Contributor
Author
|
Once this is passed, I am leaning towards cherry-pick the changes into |
Contributor
Author
|
Got LGTM, merging |
QilongTang
added a commit
that referenced
this pull request
Apr 2, 2019
* Exclude Test PDB files * Simplify the change
7 tasks
QilongTang
added a commit
that referenced
this pull request
Apr 2, 2019
* Kicking off DynamoCoreSymbols Nuget Package (#9608) * Alter build package batch file and create new nuspec * Add comments and improve console messaging * exclude pdb files not owned by Dynamo team * Update all the licencing info * Exclude Dynamo Test PDB (#9615) * Exclude Test PDB files * Simplify the change * nuget release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
Follow up PR of #9608. After discussion with other component teams and from internal feedback, remove the test pdb files from symbol nuget. Although it does not hurt, it will be clearer this way.
Latest result:

Declarations
Check these if you believe they are true
*.resxfilesReviewers
@aparajit-pratap @mjkkirschner
FYIs
@DynamoDS/dynamo